NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

fix: replace http.DefaultClient in telemetry with dedicated client#20247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugodutka merged 1 commit intomainfromfix/telemetry-http-client

Oct 9, 2025

Merged

fix: replace http.DefaultClient in telemetry with dedicated client#20247

hugodutka merged 1 commit intomainfromfix/telemetry-http-client

Oct 9, 2025

+1 −1

Conversation

Copy link

Contributor

hugodutka commentedOct 9, 2025

Replaces a call to the http default client in telemetry.go. Looks like it was missed in#20128.

fix: replace http.DefaultClient in telemetry with dedicated client

8f753c1

Fixescoder/internal#645The telemetry reporter was using http.DefaultClient which is sharedglobally. When other tests call CloseIdleConnections on the defaultclient, it causes the telemetry HTTP request to fail with"http: CloseIdleConnections called", leading to test flakes.This change replaces http.DefaultClient with the dedicated r.clientthat is already initialized in the remoteReporter struct.Co-authored-by: hugodutka <28019628+hugodutka@users.noreply.github.com>