- Notifications
You must be signed in to change notification settings - Fork1k
feat(cli): add SSH commit signing support with gitsign command#20245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
michaelbeutler wants to merge2 commits intocoder:mainChoose a base branch frommichaelbeutler:main
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+166 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add gitsign command and SSH signing configuration to enable users to sign Git commits using their Coder SSH keys as an alternative to GPG signing.- Add gitsign command that retrieves SSH keys from agent and signs commit messages- Configure agent environment to enable SSH signing in Git (gpg.format=ssh)- Add comprehensive test coverage for both CLI command and agent configuration- Implement secure temporary key file handling with automatic cleanup- Follow existing gitssh patterns for authentication and key management
github-actionsbot commentedOct 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
cdrci2 added a commit to coder/cla that referenced this pull requestOct 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds SSH commit signing functionality to Coder, enabling users to sign Git commits using their Coder SSH keys as an alternative to GPG signing. This builds on the existing Git SSH authentication system to provide a seamless signing experience.
Changes
New CLI Command
coder gitsign
: Hidden command that retrieves SSH keys from the agent and signs commit messages usingssh-keygen -Y sign
gitssh
commandAgent Environment Configuration
GIT_CONFIG_GLOBAL
environment variablegpg.format=ssh
- enables SSH signing modegpg.ssh.program=coder gitsign
- points to our signing commandcommit.gpgsign=false
- prevents automatic signing (user controlled)Test Coverage
TestGitSign
with basic operation and key retrieval verificationTestAgent_GitConfig
validates environment variable setupHow It Works
GIT_CONFIG_GLOBAL
coder gitsign
ssh-keygen -Y sign
to sign the commit messageUsage
Users automatically get SSH commit signing enabled in Coder workspaces. Git will use their Coder SSH key to sign commits when configured to do so, providing an alternative to GPG signing without additional setup.
Testing
Related
gitssh
commandAI Contribution Notice: This implementation was developed with AI assistance following Coder'sAI Contribution Guidelines. All code has been reviewed for correctness, security, and alignment with existing patterns.