Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(coderd/database): add task status and status view#20235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mafredri wants to merge2 commits intographite-base/20235
base:graphite-base/20235
Choose a base branch
Loading
frommafredri/feat-coderd-tasks-data-model-split4_split

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedOct 9, 2025
edited
Loading

This change updates thetask_workspace_apps table structure for
improved linking to workspace builds and adds queries to manage tasks
and a view to expose task status.

Updatescoder/internal#948
Supersedes#20212
Supersedes#19773

This change updates the `task_workspace_apps` table structure forimproved linking to workspace builds and adds queries to manage tasksand a view to expose task status.Updatescoder/internal#948Supersedes#20212Supersedes#19773
@mafredriGraphite App
Copy link
MemberAuthor

mafredri commentedOct 9, 2025
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
Learn more

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@mafredrimafredri changed the base branch frommafredri/feat-coderd-tasks-data-model-split4 tographite-base/20235October 9, 2025 10:40
@mafredrimafredri marked this pull request as ready for reviewOctober 9, 2025 10:41
agentState:database.WorkspaceAgentLifecycleStateReady,
appHealths: []database.WorkspaceAppHealth{database.WorkspaceAppHealthHealthy,database.WorkspaceAppHealthHealthy},
expectedStatus:database.TaskStatusActive,
description:"Running job with ready agent and multiple healthy apps should be active",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One healthy and one unhealthy app will be error, correct?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, looks like I've missed the removal of a multi-app tests. We don't care about non-task app health so they're pointless. I'll make the second one unhealthy though and that way we test that health is still OK for task.

johnstcn reacted with thumbs up emoji
@mafredrimafredriforce-pushed themafredri/feat-coderd-tasks-data-model-split4_split branch froma05d8dc tof805f37CompareOctober 9, 2025 12:58
@mafredrimafredri changed the base branch fromgraphite-base/20235 tomafredri/feat-coderd-tasks-data-model-split4October 9, 2025 12:58
@mafredrimafredri changed the base branch frommafredri/feat-coderd-tasks-data-model-split4 tographite-base/20235October 9, 2025 13:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@johnstcn@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp