Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: allow unhanger to unhang dormant workspaces#20229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 3 commits intomainfromdean/unhanger-rbac-fix
Oct 9, 2025

Conversation

deansheather
Copy link
Member

Adatabase.Workspace could either be aResourceWorkspace or a ResourceDormantWorkspace.

I believe this is what happened to this customer:

2025-10-04 18:16:57.376 [erro]  error forcefully terminating provisioner job  job_id=xyz  type=hung ...    error= in tx:               github.com/coder/coder/v2/coderd/jobreaper.reapJob                   /home/runner/work/coder/coder/coderd/jobreaper/detector.go:377             - execute transaction:               github.com/coder/coder/v2/coderd/database.(*sqlQuerier).runTx                   /home/runner/work/coder/coder/coderd/database/db.go:213             - get provisioner job:               github.com/coder/coder/v2/coderd/jobreaper.reapJob.func1                   /home/runner/work/coder/coder/coderd/jobreaper/detector.go:248             - fetch related workspace build:               github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).authorizeProvisionerJob                   /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:1245             - unauthorized: rbac: forbidden

@ibetitsmike
Copy link
Contributor

LGTM, my b about the RBAC for Dormant WS. Pity we didn't pick this up on dogfood.

@deansheather
Copy link
MemberAuthor

Yeah it's pretty unintuitive that it dormant workspaces are a different resource type

@deansheatherdeansheather merged commit8942b50 intomainOct 9, 2025
30 checks passed
@deansheatherdeansheather deleted the dean/unhanger-rbac-fix branchOctober 9, 2025 06:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ibetitsmikeibetitsmikeibetitsmike approved these changes

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@deansheather@ibetitsmike

[8]ページ先頭

©2009-2025 Movatter.jp