- Notifications
You must be signed in to change notification settings - Fork1k
feat(scaletest): extend notifications runner with smtp support#20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kacpersaw wants to merge2 commits intokacpersaw/scaletest-smtp-mock-serverChoose a base branch fromkacpersaw/scaletest-notifications-smtp
base:kacpersaw/scaletest-smtp-mock-server
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
feat(scaletest): extend notifications runner with smtp support#20222
kacpersaw wants to merge2 commits intokacpersaw/scaletest-smtp-mock-serverfromkacpersaw/scaletest-notifications-smtp
+401 −44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
kacpersaw commentedOct 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
d943527
to9411ea4
Compare5830a76
to20790fc
Compare0ef3799
to7c9356f
Compare7c9356f
todf56754
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR extends the scaletest notification runner with SMTP support.
If the
--smtp-api-url
flag is provided, the runner will also watch for SMTP notifications using the specified URL.Changes
notification_id
andnotification_type
labelsCLI Flags
--smtp-api-url
: Address of the SMTP mock HTTP API used to retrieve email notificationsMetrics
notification_delivery_latency_seconds
now includes:notification_id
notification_type
(websocket
orsmtp
)