- Notifications
You must be signed in to change notification settings - Fork1k
chore: replace MUI tables#20201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
luckily ignoring whitespace changes makes the diff waaaaaay smaller. 😄
seems pretty straight forward, one comment about types tho
| /> | ||
| )); | ||
| const_TableFooter=React.forwardRef< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
how did this end up unused?
BrunoQuaresmaOct 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The tables we had weren’t using it 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it's not really doing anything novel/complicated. I would rather we delete unused code than ignore it.
Uh oh!
There was an error while loading.Please reload this page.
aslilac left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd rather delete looks good!TableFooter and dig it up later when we need it than leave it around, but otherwise
edit: I just realized I'm dense and was reading it backwards. we weren't using it before, we are using it now. 🤦♀️
Uh oh!
There was an error while loading.Please reload this page.
I tried to break this work into smaller pieces, but since there are a lot of dependent components, I decided to handle it in one larger chunk and rely on Storybook to catch any bugs.
That said, let me know if you’d prefer a different approach!