Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: migrate MUI icons to lucide-react#20193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 5 commits intomainfrombq/migrate-mui-icons-10
Oct 8, 2025

Conversation

@BrunoQuaresma
Copy link
Contributor

No description provided.

@BrunoQuaresmaBrunoQuaresma requested a review froma teamOctober 7, 2025 13:29
@BrunoQuaresmaBrunoQuaresma self-assigned thisOct 7, 2025
@BrunoQuaresmaBrunoQuaresma requested review frombuenos-nachos and removed request fora teamOctober 7, 2025 13:29
@buenos-nachos
Copy link
Contributor

Just reviewed all the stories. I really like a lot of the changes, but some icons got way too big, and I think a couple of UI elements could be tweaked

I accepted all the stories that I had zero issue with. The only rejected stories are the ones that I think absolutely need to change. Everything else was checked, and while I was unsure about the changes, I think I could be talked into accepting them pretty easily

BrunoQuaresma reacted with heart emoji

@BrunoQuaresma
Copy link
ContributorAuthor

@Parkreiner I reviewed all your comments and made the requested changes. Thanks for the feedback — it was super helpful! 🙏

Copy link
Contributor

@buenos-nachosbuenos-nachos left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I caught a really small bug that affects the markup output in a weird way, but definitely not worth blocking over. Approving to get you unstuck

/>
)}
<span
className={`${info.hasDiff&&"text-content-warning"}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, this looks like a bug. Ifinfo.hasDiff evaluates tofalse, we'll short-circuit and not evaluate the string. But then the expression will still befalse, and we'll put that in the template literal, so then we'll haveclass="false" in the HTML

Feel likecn is probably the easiest way to fix this

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresmaBrunoQuaresma merged commit4b8d739 intomainOct 8, 2025
44 of 47 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/migrate-mui-icons-10 branchOctober 8, 2025 18:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacAwaiting requested review from aslilac

1 more reviewer

@buenos-nachosbuenos-nachosbuenos-nachos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrunoQuaresma@buenos-nachos
[8]ページ先頭
©2009-2025 Movatter.jp