- Notifications
You must be signed in to change notification settings - Fork1k
chore: fix biome error when running make lint#20182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll let Kayla chime in since she has a lot more context for Biome, but I feel like this isn't a deep enough fix for this problem, and we'll run into it again pretty soon
site/biome.jsonc Outdated
| "includes": ["!e2e/**/*Generated.ts"] | ||
| }, | ||
| "$schema":"https://biomejs.dev/schemas/2.2.0/schema.json" | ||
| "$schema":"https://biomejs.dev/schemas/2.2.4/schema.json" |
ParkreinerOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think my biggest concern is that this feels like it's kicking the can down the road, and we'll have this problem again at some point. Like, if we update Biome to version2.10.11, but forget to update the schema, wouldn't that cause the same problem again?
I was looking at the documentation, though, and it looks like we can specify that we want the schema included innode_modules, which seems a lot more resilient to me
{"$schema":"./node_modules/@biomejs/biome/configuration_schema.json"}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That’s true — let me fix that.
Also, I'm a little unclear on why the top-level |
@Parkreiner Thanks for the heads up! I’ve updated both configurations to use the installed package version, as mentioned in the docs:https://biomejs.dev/reference/configuration/#schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Since the current issue is breaking CI, I’m going to merge this. Feel free to reach out if you spot any improvements we can make here. |
1783ee1 intomainUh oh!
There was an error while loading.Please reload this page.
Parkreiner commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ah, yeah, sorry, I think I'm still waking up, so I didn't put 2 and 2 together and realize that CI was probably broken right now |
Fixes a Biome lint error when running
make lint.