- Notifications
You must be signed in to change notification settings - Fork928
feat: enforce template-level constraints for TTL and autostart#2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
20 commits Select commitHold shift + click to select a range
1713431
RED: add failing unit tests
johnstcnf11f942
RED: add migrations and make gen
johnstcnc5c9a7a
ORANGE: fix audit/diff tests
johnstcn74f4dee
fixup! RED: add migrations and make gen
johnstcn7da27a0
fixup! RED: add migrations and make gen
johnstcn5ad048b
feat: schedule: add schedule.Min function to determine minimum interval
johnstcn65b980e
ORANGE: coderd: fix a whole bunch of tests
johnstcnaa298a6
RED: fast-fail some slow-failing tests
johnstcna5ec9bf
GREEN: fix even more tests
johnstcna6255d6
GREEN: fix final unit test
johnstcn245795e
cli: templatecreate: add CLI flags --max-ttl --min-autostart-interval
johnstcn709db5b
fixup! cli: templatecreate: add CLI flags --max-ttl --min-autostart-i…
johnstcnc4a0927
make gen
johnstcn244e479
update test entities
johnstcn60ef479
Merge remote-tracking branch 'origin/main' into 1433-template-constra…
johnstcnc9aab8b
fixup! Merge remote-tracking branch 'origin/main' into 1433-template-…
johnstcnf997af2
coderd: default newly-minted workspaces to template max_ttl
johnstcnd7f697b
address PR comment
johnstcnebe4c15
fix broken unit test
johnstcn08ef2eb
fix some more tests
johnstcnFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
GREEN: fix final unit test
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita6255d69fc93674cd223b1b74acbe03a55b7f67c
There are no files selected for viewing
11 changes: 7 additions & 4 deletionscoderd/autobuild/executor/lifecycle_executor_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.