- Notifications
You must be signed in to change notification settings - Fork1k
chore: fix api param name#20172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| tags:=p.JSONStringMap(qp, database.StringMap{},"tags") | ||
| initiatorID:=p.UUID(qp,uuid.Nil,"initiator_id") | ||
| initiatorID:=p.UUID(qp,uuid.Nil,"initiator") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just checking; you're saying this will change in future work? If so, then 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The name of the parameter will remain "initiator". The valid domain for the param will expand from being a valid uuid to also being the name of any existing user, or the special value "me"
a7c9e62 intomainUh oh!
There was an error while loading.Please reload this page.
In#20137, we added a new flag to
coder provisioner jobs list, namely--initiator.To make some follow-up worth it, I need to rename an API param used in the process before it becomes part of our released and tagged API.
Instead of only accepting UUIDs, we accept an arbitrary string.
We still validate it as a UUID now, but we will expand its validation to allow any string and then resolve that string the same way that we resolve the user parameter elsewhere in the API.