- Notifications
You must be signed in to change notification settings - Fork1k
chore(provisioner): support updated coder_ai_task resource#20160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
DanielleMaywood wants to merge4 commits intomainChoose a base branch fromdanielle/tasks/provisioner
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
193a93b
to18a58db
Compare Comment on lines +600 to +606
// TODO(DanielleMaywood): | ||
// Plumb a task prompt into this when we have the new data-model ready | ||
vartaskPromptstring | ||
// TODO(DanielleMaywood): | ||
// Plumb a task ID into this when we have the new data-model ready | ||
vartaskIDstring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These will be hooked up later on once we start creating these resources
0c212b5
todf1845a
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#978
CODER_TASK_ID
andCODER_TASK_PROMPT
to the provisioner environmentapp_id
field in provider, with a fallback tosidebar_app.id
for backwards compatibilityFor now I've left the
taskPrompt
andtaskID
as a TODO as we do not yet create these values.