Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: only show error once when failing to update org member roles#20155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 4 commits intomainfromlilac/fix-org-member-role-flake
Oct 3, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedOct 2, 2025
edited
Loading

Closescoder/internal#1030

the flake stems from the fact that we're showing both a toast with the error, and it's being displayed persistently withErrorAlert. sometimes the assert would happen before the toast rendered, allowing the test to pass.

as recently discussed, showing toasts for errors is not a best practice, especially when showing the error persistently withErrorAlert is a good possibility. we're already doing that, so the toast is redundant.

BrunoQuaresma reacted with thumbs up emoji
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just have one observation, but it’s not a blocker.

@aslilacaslilac merged commit2ec9be2 intomainOct 3, 2025
31 checks passed
@aslilacaslilac deleted the lilac/fix-org-member-role-flake branchOctober 3, 2025 20:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: OrganizationMembersPage error message test - multiple elements found
3 participants
@aslilac@BrunoQuaresma@Parkreiner

[8]ページ先頭

©2009-2025 Movatter.jp