Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd): truncate task prompt to 160 characters in notifications#20147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 4 commits intomainfromcj/notifications/truncate-task-prompt
Oct 2, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedOct 2, 2025•
edited
Loading

Truncates the task prompt used in notifications to a maximum of 160 characters. The length of 160 characters was chosen arbitrarily.

@johnstcnjohnstcn self-assigned thisOct 2, 2025
@johnstcnjohnstcn changed the titlefix(notifications): truncate task prompt to 160 characters in notificationsfix(coderd): truncate task prompt to 160 characters in notificationsOct 2, 2025
Copy link
Contributor

@ssncferreirassncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍
Non-blocking nit: since the current truncation may cut a word in half, maybe we could trim to the last space before the 160-char limit and then append "...". That way notifications don’t have half words.

johnstcn reacted with thumbs up emoji
@johnstcn
Copy link
MemberAuthor

LGTM 👍 Non-blocking nit: since the current truncation may cut a word in half, maybe we could trim to the last space before the 160-char limit and then append "...". That way notifications don’t have half words.

Addressed in018e920

ssncferreira reacted with rocket emoji

@johnstcnjohnstcn merged commitffcb7a1 intomainOct 2, 2025
30 checks passed
@johnstcnjohnstcn deleted the cj/notifications/truncate-task-prompt branchOctober 2, 2025 18:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ssncferreirassncferreirassncferreira approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@ssncferreira
[8]ページ先頭
©2009-2025 Movatter.jp