Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: check permission to update username#20139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 3 commits intomainfromfix-19764
Oct 2, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletionscoderd/users.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -753,6 +753,14 @@ func (api *API) putUserProfile(rw http.ResponseWriter, r *http.Request) {
if !httpapi.Read(ctx, rw, r, &params) {
return
}

// If caller wants to update user's username, they need "update_users" permission.
// This is restricted to user admins only.
if params.Username != user.Username && !api.Authorize(r, policy.ActionUpdate, user) {
httpapi.ResourceNotFound(rw)
return
}

existentUser, err := api.Database.GetUserByEmailOrUsername(ctx, database.GetUserByEmailOrUsernameParams{
Username: params.Username,
})
Expand Down
63 changes: 58 additions & 5 deletionscoderd/users_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1051,7 +1051,7 @@ func TestUpdateUserProfile(t *testing.T) {
require.Equal(t, database.AuditActionWrite, auditor.AuditLogs()[numLogs-1].Action)
})

t.Run("UpdateSelfAsMember", func(t *testing.T) {
t.Run("UpdateSelfAsMember_Name", func(t *testing.T) {
t.Parallel()
auditor := audit.NewMock()
client := coderdtest.New(t, &coderdtest.Options{Auditor: auditor})
Expand All@@ -1060,29 +1060,82 @@ func TestUpdateUserProfile(t *testing.T) {
firstUser := coderdtest.CreateFirstUser(t, client)
numLogs++ // add an audit log for login

memberClient,_ := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID)
memberClient,memberUser := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID)
numLogs++ // add an audit log for user creation

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

newUsername := coderdtest.RandomUsername(t)
newName := coderdtest.RandomName(t)
userProfile, err := memberClient.UpdateUserProfile(ctx, codersdk.Me, codersdk.UpdateUserProfileRequest{
Username: newUsername,
Name: newName,
Username: memberUser.Username,
})
numLogs++ // add an audit log for user update
numLogs++ // add an audit log for API key creation

require.NoError(t, err)
require.Equal(t,newUsername, userProfile.Username)
require.Equal(t,memberUser.Username, userProfile.Username)
require.Equal(t, newName, userProfile.Name)

require.Len(t, auditor.AuditLogs(), numLogs)
require.Equal(t, database.AuditActionWrite, auditor.AuditLogs()[numLogs-1].Action)
})

t.Run("UpdateSelfAsMember_Username", func(t *testing.T) {
t.Parallel()
auditor := audit.NewMock()
client := coderdtest.New(t, &coderdtest.Options{Auditor: auditor})

firstUser := coderdtest.CreateFirstUser(t, client)
memberClient, memberUser := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID)

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

newUsername := coderdtest.RandomUsername(t)
_, err := memberClient.UpdateUserProfile(ctx, codersdk.Me, codersdk.UpdateUserProfileRequest{
Name: memberUser.Name,
Username: newUsername,
})

var apiErr *codersdk.Error
require.ErrorAs(t, err, &apiErr)
require.Equal(t, http.StatusNotFound, apiErr.StatusCode())
})

t.Run("UpdateMemberAsAdmin_Username", func(t *testing.T) {
t.Parallel()
auditor := audit.NewMock()
adminClient := coderdtest.New(t, &coderdtest.Options{Auditor: auditor})
numLogs := len(auditor.AuditLogs())

adminUser := coderdtest.CreateFirstUser(t, adminClient)
numLogs++ // add an audit log for login

_, memberUser := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID)
numLogs++ // add an audit log for user creation

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

newUsername := coderdtest.RandomUsername(t)
userProfile, err := adminClient.UpdateUserProfile(ctx, codersdk.Me, codersdk.UpdateUserProfileRequest{
Name: memberUser.Name,
Username: newUsername,
})

numLogs++ // add an audit log for user update
numLogs++ // add an audit log for API key creation

require.NoError(t, err)
require.Equal(t, newUsername, userProfile.Username)
require.Equal(t, memberUser.Name, userProfile.Name)

require.Len(t, auditor.AuditLogs(), numLogs)
require.Equal(t, database.AuditActionWrite, auditor.AuditLogs()[numLogs-1].Action)
})

t.Run("InvalidRealUserName", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp