Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: backport various downgrades from main#20133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 3 commits intorelease/2.27fromdean/backport-js-downgrades
Oct 2, 2025

Conversation

deansheather
Copy link
Member

JS downgrades + makechanges a required job

BrunoQuaresmaand others added3 commitsOctober 2, 2025 02:19
The upgrade caused the following error:```node: ../deps/uv/src/unix/stream.c:456: uv__stream_destroy: Assertion `!uv__io_active(&stream->io_watcher, POLLIN | POLLOUT)' failed.```After downgrading `msw`, a new error appeared only in`WorkspacesPage.test.tsx`:```<--- Last few GCs --->[2799:0x292c2000]    16790 ms: Scavenge 336.1 (443.3) -> 322.8 (443.3) MB, pooled: 32 MB, 6.45 / 0.00 ms  (average mu = 0.997, current mu = 0.996) allocation failure;[2799:0x292c2000]    16883 ms: Scavenge 336.7 (443.3) -> 326.8 (443.3) MB, pooled: 32 MB, 8.29 / 0.00 ms  (average mu = 0.997, current mu = 0.996) allocation failure;[2799:0x292c2000]    16989 ms: Scavenge 339.6 (443.3) -> 329.1 (443.3) MB, pooled: 32 MB, 9.87 / 0.00 ms  (average mu = 0.997, current mu = 0.996) allocation failure;```After some debugging, I traced it to `@radix-ui/dialog`. I didn’t findany open issues about memory leaks there, so my guess is it’s just usingmore memory than our default allocation. Jest has an option to increasethe memory limit, but we should be fine for now.Related issue:[https://github.com/mswjs/msw/issues/2537](https://github.com/mswjs/msw/issues/2537)(cherry picked from commit0fbe21e)
Earlier today, a dependabot PR was merged despite CI not having been run.#20068This was because the `changes` job failed due to a github ratelimit, which caused all the tests to be skipped, which caused `required` to pass as it passes if tests are skipped.<img width="725" height="872" alt="image" src="https://github.com/user-attachments/assets/3a13d19b-819a-48df-ad8c-e9ff903a0496" />This PR makes `changes` required so this can't happen again (assuming we keep around the dependabot automerge around, it might).(cherry picked from commit76d6e13)
@deansheatherdeansheather merged commitff69ed6 intorelease/2.27Oct 2, 2025
34 of 36 checks passed
@deansheatherdeansheather deleted the dean/backport-js-downgrades branchOctober 2, 2025 02:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac is a code owner

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@deansheather@ethanndickson@BrunoQuaresma@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp