NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

fix(coderd): ensure agent WebSocket conn is cleaned up (#19711)#20094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

stirby merged 1 commit intorelease/2.26fromcj/cherry-2.26/gh-19711

Oct 1, 2025

Merged

fix(coderd): ensure agent WebSocket conn is cleaned up (#19711)#20094

stirby merged 1 commit intorelease/2.26fromcj/cherry-2.26/gh-19711

Oct 1, 2025

Conversation

Copy link

Member

johnstcn commentedOct 1, 2025

When clients disconnected from the /containers/watch endpoint, the WebSocket connection between coderd and the agent stayed open. This caused heartbeat traffic every 15s that was incorrectly counted as workspace activity, extending workspace lifetimes indefinitely.

Now properly cancels the agent connection context when the client disconnects.

(cherry picked from commite12b621)

fix(coderd): ensure agent WebSocket conn is cleaned up (#19711)

511fb22

When clients disconnected from the /containers/watch endpoint, the WebSocketconnection between coderd and the agent stayed open. This caused heartbeattraffic every 15s that was incorrectly counted as workspace activity,extending workspace lifetimes indefinitely.Now properly cancels the agent connection context when the client disconnects.(cherry picked from commite12b621)