- Notifications
You must be signed in to change notification settings - Fork1k
feat: minor prompt redesign#20045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In general a fan of the visual changes, agree the text prompt wasn't prominent enough.
| <fieldset | ||
| className="border border-border border-solid rounded-lg p-4" | ||
| className="border border-border border-solid rounded-3xl p-3 bg-surface-secondary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: Not the biggest fan of the extra rounding. Feels inconsistent with the other elements on the page. I'm not a designer though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I had the same feeling, but the non-rounded version looked even stranger to me, even though it’s inconsistent 🤔. Here’s how it looks without the extra rounding:
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I see what you're saying. Ipersonally prefer this one but again: not a designer haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You may not be a designer, but I know you’ve got good taste. I’ll create a poll and see what others think haha.
@ben I’m going to merge this, and I can reduce the border radius if you think that would look better. Thanks for the review! |
f009ebd intomainUh oh!
There was an error while loading.Please reload this page.
I think you tagged the wrong ben haha 😎 and all good :) |
LMAO |
When I navigate to tasks, the prompt doesn’t feel prominent enough—even though it should be the primary element on the screen. To give it more focus, I made some small design changes. Here are both versions:
Before:
After:
