- Notifications
You must be signed in to change notification settings - Fork1k
feat: add workspace status on tasks#20037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changes look good!
<WorkspaceDormantBadge workspace={workspace} /> | ||
)} | ||
</WorkspaceStatusIndicator> | ||
<span className="text-xs font-medium text-content-secondary ml-6 whitespace-nowrap"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we can swap in atime
element here (we'd just need to also add adatetime
attribute that receivesworkspace.last_used_at
property directly, too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
100%—thanks for calling this out. I always forget about this semantic HTML element for timings.
…-ws-status-on-tasks
…-ws-status-on-tasks
6b61c8a
intomainUh oh!
There was an error while loading.Please reload this page.
Closes#19988