- Notifications
You must be signed in to change notification settings - Fork1k
feat: add cli command scaletest dynamic-parameters#20034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletionscli/exp_scaletest.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletionscli/exp_scaletest_dynamicparameters.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| //go:build !slim | ||
| package cli | ||
| import ( | ||
| "fmt" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "golang.org/x/xerrors" | ||
| "cdr.dev/slog" | ||
| "cdr.dev/slog/sloggers/sloghuman" | ||
| "github.com/coder/coder/v2/scaletest/dynamicparameters" | ||
| "github.com/coder/coder/v2/scaletest/harness" | ||
| "github.com/coder/serpent" | ||
| ) | ||
| const ( | ||
| dynamicParametersTestName = "dynamic-parameters" | ||
| ) | ||
| func (r *RootCmd) scaletestDynamicParameters() *serpent.Command { | ||
| var templateName string | ||
| var numEvals int64 | ||
| orgContext := NewOrganizationContext() | ||
| output := &scaletestOutputFlags{} | ||
| cmd := &serpent.Command{ | ||
| Use: "dynamic-parameters", | ||
| Short: "Generates load on the Coder server evaluating dynamic parameters", | ||
| Long: `It is recommended that all rate limits are disabled on the server before running this scaletest. This test generates many login events which will be rate limited against the (most likely single) IP.`, | ||
| Handler: func(inv *serpent.Invocation) error { | ||
| ctx := inv.Context() | ||
| outputs, err := output.parse() | ||
| if err != nil { | ||
| return xerrors.Errorf("could not parse --output flags") | ||
| } | ||
| client, err := r.InitClient(inv) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if templateName == "" { | ||
| return xerrors.Errorf("template cannot be empty") | ||
| } | ||
| org, err := orgContext.Selected(inv, client) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| logger := slog.Make(sloghuman.Sink(inv.Stdout)).Leveled(slog.LevelDebug) | ||
| partitions, err := dynamicparameters.SetupPartitions(ctx, client, org.ID, templateName, numEvals, logger) | ||
| if err != nil { | ||
| return xerrors.Errorf("setup dynamic parameters partitions: %w", err) | ||
| } | ||
| th := harness.NewTestHarness(harness.ConcurrentExecutionStrategy{}, harness.ConcurrentExecutionStrategy{}) | ||
| reg := prometheus.NewRegistry() | ||
Member
| ||
| metrics := dynamicparameters.NewMetrics(reg, "concurrent_evaluations") | ||
| for i, part := range partitions { | ||
| for j := range part.ConcurrentEvaluations { | ||
| cfg := dynamicparameters.Config{ | ||
| TemplateVersion: part.TemplateVersion.ID, | ||
| Metrics: metrics, | ||
| MetricLabelValues: []string{fmt.Sprintf("%d", part.ConcurrentEvaluations)}, | ||
| } | ||
| runner := dynamicparameters.NewRunner(client, cfg) | ||
| th.AddRun(dynamicParametersTestName, fmt.Sprintf("%d/%d", j, i), runner) | ||
| } | ||
| } | ||
| err = th.Run(ctx) | ||
| if err != nil { | ||
| return xerrors.Errorf("run test harness: %w", err) | ||
| } | ||
| res := th.Results() | ||
| for _, o := range outputs { | ||
| err = o.write(res, inv.Stdout) | ||
| if err != nil { | ||
| return xerrors.Errorf("write output %q to %q: %w", o.format, o.path, err) | ||
| } | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
| cmd.Options = serpent.OptionSet{ | ||
| { | ||
| Flag: "template", | ||
| Description: "Name of the template to use. If it does not exist, it will be created.", | ||
| Default: "scaletest-dynamic-parameters", | ||
| Value: serpent.StringOf(&templateName), | ||
| }, | ||
| { | ||
| Flag: "concurrent-evaluations", | ||
| Description: "Number of concurrent dynamic parameter evaluations to perform.", | ||
| Default: "100", | ||
| Value: serpent.Int64Of(&numEvals), | ||
| }, | ||
| } | ||
| orgContext.AttachOptions(cmd) | ||
| output.attach(&cmd.Options) | ||
| return cmd | ||
| } | ||
10 changes: 10 additions & 0 deletionscodersdk/client.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletionscaletest/dynamicparameters/config.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 changes: 1 addition & 5 deletionsscaletest/dynamicparameters/run.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletionscaletest/dynamicparameters/run_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.