Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add cli command scaletest dynamic-parameters#20034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 30, 2025•
edited
Loading

part ofcoder/internal#912

Adds CLI commandcoder exp scaletest dynamic-parameters

I've left out the configuration of tracing and timeouts for now. I think I want to do some refactoring of the scaletest CLI to make handling those flags take up less boiler plate.

I will add tracing and timeout flags in a follow up PR.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 30, 2025 17:24
metrics:=dynamicparameters.NewMetrics(reg,"concurrent_evaluations")

fori,part:=rangepartitions {
forj:=0;j<part.ConcurrentEvaluations;j++ {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit:

Suggested change
forj:=0;j<part.ConcurrentEvaluations;j++ {
forj:=rangepart.ConcurrentEvaluations {

}

th:=harness.NewTestHarness(harness.ConcurrentExecutionStrategy{}, harness.ConcurrentExecutionStrategy{})
reg:=prometheus.NewRegistry()
Copy link
Member

@ethanndicksonethanndicksonOct 1, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You mentioned leaving out the tracing & timeout flags for refactoring, but don't forget about the prometheus flags & running the server for the metrics on port21112.

spikecurtis reacted with thumbs up emoji
@spikecurtisspikecurtisforce-pushed thespike/internal-912-template-version-and-cli branch frombe1b513 to9fa1ed0CompareOctober 1, 2025 10:12
@spikecurtisspikecurtisforce-pushed thespike/internal-912-template-version-and-cli branch from9fa1ed0 to1c3e589CompareOctober 7, 2025 12:03
@spikecurtisspikecurtis merged commit65335bc intomainOct 7, 2025
32 checks passed
@spikecurtisspikecurtis deleted the spike/internal-912-template-version-and-cli branchOctober 7, 2025 17:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson left review comments

@kacpersawkacpersawkacpersaw approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@kacpersaw@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp