Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix flaky test in WorkspacePage.test.tsx#20033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 3 commits intomainfromjaaydenh/workspacepage-flake-fix
Sep 30, 2025
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletionssite/src/pages/WorkspacePage/WorkspacePage.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -309,7 +309,7 @@ describe("WorkspacePage", () => {
// Started flaking after upgrading react-router. Tests the old parameters path
// and isn't worth spending more time to fix since this code will be removed
// in a few releases when dynamic parameters takes over the world.
it.skip("updates the parameters when they are missing during update", async () => {
it("updates the parameters when they are missing during update", async () => {
// Mocks
jest
.spyOn(API, "getWorkspaceByOwnerAndName")
Expand DownExpand Up@@ -340,7 +340,9 @@ describe("WorkspacePage", () => {

// After trying to update, a new dialog asking for missed parameters should
// be displayed and filled
const dialog = await waitFor(() => screen.findByTestId("dialog"));
const dialog = await screen.findByRole("dialog", {
name: /workspace parameters/i,
});
const firstParameterInput = within(dialog).getByLabelText(
MockTemplateVersionParameter1.name,
{ exact: false },
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp