Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add heartbeat to keep dynamic params websocket open#20026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rafrdz merged 1 commit intomainfromrafrdz/dynamic-params-websocket
Oct 2, 2025

Conversation

rafrdz
Copy link

Summary

In this pull request we're adding a heartbeat to thehandleParameterWebsocket function to ensure that the connection stays open until the 30 min timeout has been reached.

Closes:#19805

Testing

  • Reproduced the problem mentioned in the issue (websocket connection closes after ~10 minutes of inactivity on the create workspace page)
Screenshot 2025-09-26 at 15 58 51
  • Confirmed that adding the heartbeat kept the connection open until the 30 min timeout was reached
Screenshot 2025-09-29 at 15 51 43

@rafrdzrafrdz changed the titlefix: add heartbeat to keep websocket openfix: add heartbeat to keep dynamic params websocket openSep 29, 2025
@rafrdzrafrdz marked this pull request as ready for reviewSeptember 29, 2025 21:05
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oh, that's easy! thanks!

rafrdz reacted with hooray emoji
@rafrdzrafrdz merged commitc517aab intomainOct 2, 2025
37 checks passed
@rafrdzrafrdz deleted the rafrdz/dynamic-params-websocket branchOctober 2, 2025 14:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@rafrdzrafrdz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Dynamic parameters websocket connections time out behind ALB due to missing heartbeat
2 participants
@rafrdz@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp