- Notifications
You must be signed in to change notification settings - Fork1k
feat: delete task from sidebar#20023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me. One thing I noticed is that our other delete dialogs (workspace, template) seem to use red for the confirm delete button but this one is white, should we do the same here? I think maybe the confirm dialog just needs atype="delete" (which would also make settingconfirmText andhideCancel not required).
@code-asher good catch! I’d forgotten about the |
e96d69b intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This adds a way to delete a task from the sidebar. Once this PR is merged, I’ll also add the option to the table list.
cut-demo.mov
Right now, after deleting a task, the data still shows—that’s a separate issue related to how task data is loaded in the FE. A proper tasks endpoint is now available, and that should be addressed as part ofcoder/internal#904.
Related to#19525