- Notifications
You must be signed in to change notification settings - Fork927
fix: ensure listen websocket isn't opened for non-latest agents#2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
kylecarbs approved these changesJun 2, 2022
Uh oh!
There was an error while loading.Please reload this page.
Exponential backoff is only enabled if the websocket fails to open. Ifthe websocket is opened but immediately killed, the agent will try toimmediately reconnect. This is desireable in cases where coderd is beingreplaced or network conditions cause the connection to die, but not forpermanent errors.
1e00749 to7355d57Comparekylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Exponential backoff is only enabled if the websocket fails to open. Ifthe websocket is opened but immediately killed, the agent will try toimmediately reconnect. This is desireable in cases where coderd is beingreplaced or network conditions cause the connection to die, but not forpermanent errors.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exponential backoff is only enabled for if the websocket fails to open.
If the websocket is opened but immediately killed, the agent will try to
immediately reconnect. This is desireable in cases where coderd is being
replaced or network conditions cause the connection to die.