Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: precompile the db cleaner on make test#20000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 2 commits intomainfromspike/internal-1026-precompile-cleaner
Sep 30, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 29, 2025
edited
Loading

We're seeing some timeouts from starting the db cleaner, e.g.coder/internal#1026

My suspicion is that in CI the go build cache might not be warm, and so it can take a while to compile and run the dbcleaner subprocess.

This fix builds the cleaner once prior to starting a test run viamake test to ensure we have a warm cache.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 29, 2025 07:15
@spikecurtisspikecurtisforce-pushed thespike/internal-1026-precompile-cleaner branch from5a5979d to30aca6fCompareSeptember 30, 2025 05:55
@spikecurtisspikecurtis merged commit2bd11df intomainSep 30, 2025
32 checks passed
@spikecurtisspikecurtis deleted the spike/internal-1026-precompile-cleaner branchSeptember 30, 2025 06:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp