Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(scaletest): make workspacebuild return the built workspace#19997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/scaletest-wsbuild-return-ws
Sep 30, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 29, 2025•
edited
Loading

Similar idea as in#19811, this runner doesn't need to conform toRunnable, so we have it return the workspace from theRunReturningWorkspace function, instead of the more fragileRun, followed by a.WorkspaceID().

@ethanndicksonethanndicksonforce-pushed theethan/coder-connect-scaletest-cmd branch from538e506 to629e04eCompareSeptember 30, 2025 00:57
@ethanndicksonethanndicksonforce-pushed theethan/scaletest-wsbuild-return-ws branch from4aca852 to604e76fCompareSeptember 30, 2025 00:58
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedSep 30, 2025•
edited
Loading

Merge activity

@ethanndicksonethanndickson changed the base branch fromethan/coder-connect-scaletest-cmd tographite-base/19997September 30, 2025 07:29
@ethanndicksonethanndickson changed the base branch fromgraphite-base/19997 tomainSeptember 30, 2025 08:07
@ethanndicksonethanndicksonforce-pushed theethan/scaletest-wsbuild-return-ws branch from604e76f toa5873d5CompareSeptember 30, 2025 08:08
@ethanndicksonethanndickson merged commitec417de intomainSep 30, 2025
32 checks passed
@ethanndicksonethanndickson deleted the ethan/scaletest-wsbuild-return-ws branchSeptember 30, 2025 08:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp