- Notifications
You must be signed in to change notification settings - Fork1k
feat: add scoped token support to CLI#19985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ThomasK33 wants to merge1 commit intothomask33/09-26-add_api_key_patch_endpointChoose a base branch
base:thomask33/09-26-add_api_key_patch_endpoint
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletionscli/testdata/coder_tokens_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletionscli/testdata/coder_tokens_create_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletioncli/testdata/coder_tokens_list_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletionscli/testdata/coder_tokens_view_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| coder v0.0.0-devel | ||
| USAGE: | ||
| coder tokens view [flags] <name|id> | ||
| Display detailed information about a token | ||
| OPTIONS: | ||
| -c, --column [id|name|scopes|allow list|last used|expires at|created at|owner] (default: id,name,scopes,allow list,last used,expires at,created at,owner) | ||
| Columns to display in table output. | ||
| -o, --output table|json (default: table) | ||
| Output format. | ||
| ——— | ||
| Run `coder --help` for a list of global options. |
110 changes: 105 additions & 5 deletionscli/tokens.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletionscli/tokens_allowlist_flag.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package cli | ||
| import ( | ||
| "strings" | ||
| "golang.org/x/xerrors" | ||
| "github.com/coder/coder/v2/codersdk" | ||
| ) | ||
| // allowListFlag implements pflag.SliceValue for codersdk.APIAllowListTarget entries. | ||
| type allowListFlag struct { | ||
| targets *[]codersdk.APIAllowListTarget | ||
| } | ||
| func newAllowListFlag(dst *[]codersdk.APIAllowListTarget) *allowListFlag { | ||
| return &allowListFlag{targets: dst} | ||
| } | ||
| func (a *allowListFlag) ensureSlice() error { | ||
| if a.targets == nil { | ||
| return xerrors.New("allow list destination is nil") | ||
| } | ||
| if *a.targets == nil { | ||
| *a.targets = make([]codersdk.APIAllowListTarget, 0) | ||
| } | ||
| return nil | ||
| } | ||
| func (a *allowListFlag) String() string { | ||
| if a.targets == nil || len(*a.targets) == 0 { | ||
| return "" | ||
| } | ||
| parts := make([]string, len(*a.targets)) | ||
| for i, t := range *a.targets { | ||
| parts[i] = t.String() | ||
| } | ||
| return strings.Join(parts, ",") | ||
| } | ||
| func (a *allowListFlag) Set(raw string) error { | ||
| if err := a.ensureSlice(); err != nil { | ||
| return err | ||
| } | ||
| raw = strings.TrimSpace(raw) | ||
| if raw == "" { | ||
| return xerrors.New("allow list entry cannot be empty") | ||
| } | ||
| var target codersdk.APIAllowListTarget | ||
| if err := target.UnmarshalText([]byte(raw)); err != nil { | ||
| return err | ||
| } | ||
| *a.targets = append(*a.targets, target) | ||
| return nil | ||
| } | ||
| func (*allowListFlag) Type() string { return "allowList" } | ||
| func (a *allowListFlag) Append(value string) error { | ||
| return a.Set(value) | ||
| } | ||
| func (a *allowListFlag) Replace(items []string) error { | ||
| if err := a.ensureSlice(); err != nil { | ||
| return err | ||
| } | ||
| (*a.targets) = (*a.targets)[:0] | ||
| for _, item := range items { | ||
| if err := a.Set(item); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
| func (a *allowListFlag) GetSlice() []string { | ||
| if a.targets == nil { | ||
| return nil | ||
| } | ||
| out := make([]string, len(*a.targets)) | ||
| for i, t := range *a.targets { | ||
| out[i] = t.String() | ||
| } | ||
| return out | ||
| } |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.