Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor!: rename prompt field to input for task creation#19982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 1 commit intomainfromdanielle/tasks/prompt-to-input
Sep 26, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletioncli/exp_task_create.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -181,7 +181,7 @@ func (r *RootCmd) taskCreate() *serpent.Command {
Name:taskName,
TemplateVersionID:templateVersionID,
TemplateVersionPresetID:templateVersionPresetID,
Prompt:taskInput,
Input:taskInput,
})
iferr!=nil {
returnxerrors.Errorf("create task: %w",err)
Expand Down
2 changes: 1 addition & 1 deletioncli/exp_task_create_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ func TestTaskCreate(t *testing.T) {
return
}

assert.Equal(t,prompt,req.Prompt,"prompt mismatch")
assert.Equal(t,prompt,req.Input,"prompt mismatch")
assert.Equal(t,templateVersionID,req.TemplateVersionID,"template version mismatch")

ifpresetName=="" {
Expand Down
6 changes: 3 additions & 3 deletionscoderd/aitasks.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ func (api *API) tasksCreate(rw http.ResponseWriter, r *http.Request) {
if anthropicAPIKey := taskname.GetAnthropicAPIKeyFromEnv(); anthropicAPIKey != "" {
anthropicModel := taskname.GetAnthropicModelFromEnv()

generatedName, err := taskname.Generate(ctx, req.Prompt, taskname.WithAPIKey(anthropicAPIKey), taskname.WithModel(anthropicModel))
generatedName, err := taskname.Generate(ctx, req.Input, taskname.WithAPIKey(anthropicAPIKey), taskname.WithModel(anthropicModel))
if err != nil {
api.Logger.Error(ctx, "unable to generate task name", slog.Error(err))
} else {
Expand All@@ -150,7 +150,7 @@ func (api *API) tasksCreate(rw http.ResponseWriter, r *http.Request) {
TemplateVersionID: req.TemplateVersionID,
TemplateVersionPresetID: req.TemplateVersionPresetID,
RichParameterValues: []codersdk.WorkspaceBuildParameter{
{Name: codersdk.AITaskPromptParameterName, Value: req.Prompt},
{Name: codersdk.AITaskPromptParameterName, Value: req.Input},
},
}

Expand DownExpand Up@@ -216,7 +216,7 @@ func (api *API) tasksCreate(rw http.ResponseWriter, r *http.Request) {
return
}

task := taskFromWorkspace(w, req.Prompt)
task := taskFromWorkspace(w, req.Input)
httpapi.Write(ctx, rw, http.StatusCreated, task)
}

Expand Down
12 changes: 6 additions & 6 deletionscoderd/aitasks_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,7 +349,7 @@ func TestTasks(t *testing.T) {
exp := codersdk.NewExperimentalClient(client)
task, err := exp.CreateTask(ctx, "me", codersdk.CreateTaskRequest{
TemplateVersionID: template.ActiveVersionID,
Prompt: "delete me",
Input: "delete me",
})
require.NoError(t, err)
ws, err := client.Workspace(ctx, task.ID)
Expand DownExpand Up@@ -429,7 +429,7 @@ func TestTasks(t *testing.T) {
exp := codersdk.NewExperimentalClient(client)
task, err := exp.CreateTask(ctx, "me", codersdk.CreateTaskRequest{
TemplateVersionID: template.ActiveVersionID,
Prompt: "delete me not",
Input: "delete me not",
})
require.NoError(t, err)
ws, err := client.Workspace(ctx, task.ID)
Expand DownExpand Up@@ -802,7 +802,7 @@ func TestTasksCreate(t *testing.T) {
// When: We attempt to create a Task.
task, err := expClient.CreateTask(ctx, "me", codersdk.CreateTaskRequest{
TemplateVersionID: template.ActiveVersionID,
Prompt: taskPrompt,
Input: taskPrompt,
})
require.NoError(t, err)
require.True(t, task.WorkspaceID.Valid)
Expand DownExpand Up@@ -875,7 +875,7 @@ func TestTasksCreate(t *testing.T) {
// When: We attempt to create a Task.
task, err := expClient.CreateTask(ctx, "me", codersdk.CreateTaskRequest{
TemplateVersionID: template.ActiveVersionID,
Prompt: "Some prompt",
Input: "Some prompt",
Name: tt.taskName,
})
if tt.expectError == "" {
Expand DownExpand Up@@ -919,7 +919,7 @@ func TestTasksCreate(t *testing.T) {
// When: We attempt to create a Task.
_, err := expClient.CreateTask(ctx, "me", codersdk.CreateTaskRequest{
TemplateVersionID: template.ActiveVersionID,
Prompt: taskPrompt,
Input: taskPrompt,
})

// Then: We expect it to fail.
Expand DownExpand Up@@ -951,7 +951,7 @@ func TestTasksCreate(t *testing.T) {
// When: We attempt to create a Task with an invalid template version ID.
_, err := expClient.CreateTask(ctx, "me", codersdk.CreateTaskRequest{
TemplateVersionID: uuid.New(),
Prompt: taskPrompt,
Input: taskPrompt,
})

// Then: We expect it to fail.
Expand Down
2 changes: 1 addition & 1 deletioncodersdk/aitasks.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,7 @@ func (c *ExperimentalClient) AITaskPrompts(ctx context.Context, buildIDs []uuid.
type CreateTaskRequest struct {
TemplateVersionID uuid.UUID `json:"template_version_id" format:"uuid"`
TemplateVersionPresetID uuid.UUID `json:"template_version_preset_id,omitempty" format:"uuid"`
Prompt string `json:"prompt"`
Inputstring `json:"input"`
Name string `json:"name,omitempty"`
}

Expand Down
2 changes: 1 addition & 1 deletionsite/src/api/typesGenerated.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

4 changes: 2 additions & 2 deletionssite/src/pages/TasksPage/TaskPrompt.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -434,14 +434,14 @@ function sortByDefault(a: Preset, b: Preset) {
// and user action. Since handling this in the FE cannot guarantee correctness,
// we should move the logic to the BE after the experimental phase.
asyncfunctioncreateTaskWithLatestTemplateVersion(
prompt:string,
input:string,
userId:string,
templateId:string,
presetId:string|undefined,
):Promise<Task>{
consttemplate=awaitAPI.getTemplate(templateId);
returnAPI.experimental.createTask(userId,{
prompt,
input,
template_version_id:template.active_version_id,
template_version_preset_id:presetId,
});
Expand Down
2 changes: 1 addition & 1 deletionsite/src/pages/TasksPage/TasksPage.stories.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -271,7 +271,7 @@ export const CreateTaskSuccessfully: Story = {
expect(API.experimental.createTask).toHaveBeenCalledWith(
MockUserOwner.id,
{
prompt: MockNewTaskData.prompt,
input: MockNewTaskData.prompt,
template_version_id: `${MockTemplate.active_version_id}-latest`,
template_version_preset_id: undefined,
},
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp