Jun 3, 2022 · Jun 2, 2022 · Jun 2, 2022 · Jun 2, 2022 · Jun 2, 2022 · Jun 2, 2022
diff --git a/site/src/xServices/workspaceBuild/workspaceBuildXService.ts b/site/src/xServices/workspaceBuild/workspaceBuildXService.ts
        const reader = await API.streamWorkspaceBuildLogs(ctx.buildId)

        // Watching for the stream
        // eslint-disable-next-line no-constant-condition
        // eslint-disable-next-line no-constant-condition, @typescript-eslint/no-unnecessary-condition
        while (true) {
          const { value, done } = await reader.read()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -123,7 +123,7 @@ export const workspaceBuildMachine = createMachine(
		const reader = await API.streamWorkspaceBuildLogs(ctx.buildId)

		// Watching for the stream
		// eslint-disable-next-line no-constant-condition
		// eslint-disable-next-line no-constant-condition, @typescript-eslint/no-unnecessary-condition
		while (true) {
Copy link Member Kira-PilotJun 3, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Do we need to worry about error handling or cleanup if`done` never returns? Copy link CollaboratorAuthor BrunoQuaresmaJun 3, 2022• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It is a good point. I think for now we can rely on done being always called, why: We are using a polyfill(https://canjs.com/doc/can-ndjson-stream.html) because Firefox does not support some stream APIs I took a look and I didn't find anything related to "read failure" or something related If an error is thrown, it will stop the execution anyway This error, in particular, looks tricky to handle so I would expect someone having issues with that to think of a proper solution In summary, I don't know how to do that and it looks complex to handle 😆, so I would not invest too much time on that right now, but if you have an idea how to solve that, I would love to learn and implement it for sure. Kira-Pilot reacted with thumbs up emoji Copy link Member Kira-PilotJun 3, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ha! Thanks for the breakdown - what you said makes sense and I think you're right to hold off. If this becomes an issue in the future, we can look intocalling`cancel` on the ReadableStream object. BrunoQuaresma reacted with thumbs up emoji Copy link CollaboratorAuthor BrunoQuaresmaJun 3, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ahh, nice!
		const { value, done } = await reader.read()

Expand Down