- Notifications
You must be signed in to change notification settings - Fork1k
chore: migrate MUI icons to lucide icons#19967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looking through the stories, one of the icons stood out to me as weird, but the rest looked good so far. might be worth checking the rest of the stories to be sure.
| importComputerIconfrom"@mui/icons-material/Computer"; | ||
| importtype{WorkspaceApp}from"api/typesGenerated"; | ||
| import{ExternalImage}from"components/ExternalImage/ExternalImage"; | ||
| import{ComputerIcon}from"lucide-react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lucide's "computer" icon is kinda weird looking when it's this small, and is an older "monitor ontop of horizontal desktop" kinda configuration, which is odd looking these days. I think "laptop" might be a better replacement here.https://lucide.dev/icons/laptop
@aslilac Thanks for the heads-up. I went through all the stories, and I think we’re good to go now. |
403a9e5 intomainUh oh!
There was an error while loading.Please reload this page.
This PR completes the migration from Material UI icons to Lucide icons.