Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove react-helmet#19963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 7 commits intomainfrombq/remove-react-helmet
Sep 26, 2025
Merged

chore: remove react-helmet#19963

BrunoQuaresma merged 7 commits intomainfrombq/remove-react-helmet
Sep 26, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

Since React 19 supports head tags natively, we no longer need to usereact-helmet.

@BrunoQuaresmaBrunoQuaresma requested a review froma teamSeptember 25, 2025 14:45
@BrunoQuaresmaBrunoQuaresma self-assigned thisSep 25, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromParkreiner anda team and removed request fora team andParkreinerSeptember 25, 2025 14:45
aqandrew
aqandrew previously requested changesSep 25, 2025
Copy link
Contributor

@aqandrewaqandrew left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall looks great, thanks for this!

I'm just concerned about some curly brackets that were removed inRequestOTPPage andWorkspaceSettingsPage.

Other than that, we might want to renameconst helmet that's declared inIdpSyncPage and several other files--but that's not a dealbreaker

BrunoQuaresma reacted with thumbs up emoji
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

spotted a couple potential things to clean up while we're messing with our page<title>s, but the conversion looks great.

it'd be nice if we could get rid of all the blank lines this introduced in the import blocks tho.

BrunoQuaresma reacted with thumbs up emoji
Co-authored-by: ケイラ <mckayla@hey.com>Co-authored-by: Andrew Aquino <dawneraq@gmail.com>
@BrunoQuaresmaBrunoQuaresma dismissedaqandrew’sstale reviewSeptember 26, 2025 13:47

Hey — I’m dismissing this review, as I believe I’ve addressed all your comments. If I missed anything, please let me know.

@BrunoQuaresmaBrunoQuaresma merged commitd70e26d intomainSep 26, 2025
32 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/remove-react-helmet branchSeptember 26, 2025 13:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 26, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

@aqandrewaqandrewAwaiting requested review from aqandrew

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@aslilac@aqandrew
[8]ページ先頭
©2009-2025 Movatter.jp