NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

feat: redesign tasks page to match AI tools#19962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 5 commits intomainfrombq/redesign-tasks-page

Sep 26, 2025

Merged

feat: redesign tasks page to match AI tools#19962

BrunoQuaresma merged 5 commits intomainfrombq/redesign-tasks-page

Sep 26, 2025

Conversation

Copy link

Collaborator

BrunoQuaresma commentedSep 25, 2025

Demo:

feat: redesign tasks page to match AI tools

a03b5d2

BrunoQuaresma requested a review froma team

September 25, 2025 14:00

BrunoQuaresma self-assigned this

Sep 25, 2025

BrunoQuaresma requested review fromcode-asher and removed request fora team

September 25, 2025 14:00

BrunoQuaresma requested review fromaslilac andParkreiner ascode owners

September 25, 2025 14:00

fix lint

9fb4649

aslilac reviewed

Sep 25, 2025

View reviewed changes

Copy link

Member

aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

code looks fine, but are we really getting rid of the navbar?

code-asher approved these changes

Sep 25, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking snazzy. Had the same comment about the navbar, seems hard to get back to the rest of Coder.

site/src/pages/TasksPage/TaskPrompt.tsx Outdated

		onValueChange={(value)=>setSelectedTemplateId(value)}
		onValueChange={(value)=>{
		setSelectedTemplateId(value);
		setSelectedPresetId(undefined);

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PR and commit only mentions a redesign, was this a bugfix?

Copy link

CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, a minor one 👍

Copy link

Member

code-asherSep 26, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

kk just fyi I did not validate this fix since idk what the bug was

site/src/pages/TasksPage/TaskPrompt.tsx Outdated

		>
		Preset
		</label>
		{isLoadingPresets ?(

Copy link

Member

code-asherSep 25, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems this block is never entered since it is nested under thepresets check now.

On the first fetch,presets is undefined so we never show the loading skeleton.

On subsequent fetches, it seems thatisLoadingPresets is still false because there is cached data (seems weird to me, but I guess that is how it works).

So I think we can either delete the loader, or we need to move it so it is no longer nested under thepresets check like it was before.

Copy link

CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch! Removing it.

Copy link

Member

code-asher commentedSep 25, 2025

One other comment, could be nice to have a story for when the preset has a prompt defined, to see the readonly prompt behavior.

BrunoQuaresma added2 commits

September 26, 2025 15:53

Merge branch 'main' ofhttps://github.com/coder/coderinto bq/redesig…

4ad061b

…n-tasks-page

apply review comments

c96fa25

Copy link

CollaboratorAuthor

BrunoQuaresma commentedSep 26, 2025

code looks fine, but are we really getting rid of the navbar?

@aslilac Yes, we are—for now.

seems hard to get back to the rest of Coder.

I had forgotten to add a link in the Coder logo to return to the home page, but that’s fixed now.

could be nice to have a story for when the preset has a prompt defined

Good catch! I’ve added it.

fix default preset selection

e55a145

aslilac approved these changes

Sep 26, 2025

View reviewed changes

Copy link

Member

aslilac left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

approving because you said "for now" and it's still an experiment. I think we're definitely gonna need to iron out the navigation situation before this stabilizes. can we make sure there's an issue open to track that?

Copy link

CollaboratorAuthor

BrunoQuaresma commentedSep 26, 2025

This navigation is similar to what we have in the template editor. Since users can now return home by clicking the Coder logo, I think it should be fine. I’d only open an issue if we receive consistent feedback—does that make sense?

That said, if you feel strongly about the navigation, I can definitely open an issue. I’d appreciate your help describing the pain points you’re experiencing or that you think users might face.