Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd): add experimental tasks send endpoint#19941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 14 commits intomainfrommafredri/feat-coderd-tasks-send
Sep 25, 2025

Conversation

mafredri
Copy link
Member

@mafredrimafredriforce-pushed themafredri/feat-coderd-tasks-send branch 2 times, most recently from8272a1c to1bd075bCompareSeptember 24, 2025 12:46
@mafredrimafredriforce-pushed themafredri/feat-coderd-tasks-send branch from1bd075b to812b2b2CompareSeptember 24, 2025 12:55
@mafredrimafredri marked this pull request as ready for reviewSeptember 24, 2025 12:55
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The logic looks fine to me, although there are a couple of stylistic nits and some unneeded use ofhttperror.WriteResponseWriter

Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM:shipit: I'd feel happier with Cian having a second look as we already partly discussed the approach earlier

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work@mafredri !

I think we're just missing a pre-flight check on the AgentAPI/status endpoint.

mafredri reacted with thumbs up emoji
@mafredrimafredriforce-pushed themafredri/feat-coderd-tasks-send branch from20d653d tof607b45CompareSeptember 25, 2025 09:30
@mafredrimafredrienabled auto-merge (squash)September 25, 2025 11:57
@mafredrimafredri changed the titlefeat(coderd): add tasks send endpointfeat(coderd): add experimental tasks send endpointSep 25, 2025
@mafredrimafredri merged commit5317d30 intomainSep 25, 2025
56 of 58 checks passed
@mafredrimafredri deleted the mafredri/feat-coderd-tasks-send branchSeptember 25, 2025 12:12
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tasks API: ImplementPOST /tasks/{id}/send
3 participants
@mafredri@johnstcn@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp