Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: create tasks instead of workspaces in ai triage workflow#19940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 11 commits intomainfromcj/traiage/integrate-tasks
Sep 25, 2025

Conversation

johnstcn
Copy link
Member

Depends on#19939

@johnstcnjohnstcn self-assigned thisSep 24, 2025
@johnstcnjohnstcn changed the titleci: traiage: create tasks instead of workspacesci: create tasks instead of workspaces in ai triage workflowSep 24, 2025
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me although will defer to@mafredri for approval

johnstcnand others added2 commitsSeptember 24, 2025 16:24
Co-authored-by: Danielle Maywood <danielle@themaywoods.com>
Comment on lines 167 to 181
# AgentAPI must be stable
agentapi_status=$(curl \
--header"Content-Type: application/json" \
--header"Coder-Session-Token:${CODER_SESSION_TOKEN}" \
--location \
--request GET \
--show-error \
--silent \
"${CODER_URL}/@${username}/${WORKSPACE_NAME}/apps/agentapi/status"| jq -r'.status')
if [["${response}"=="stable" ]];then
"${CODER_URL}/@${username}/${TASK_NAME}/apps/${APP_SLUG}/status"| jq -r'.status')
if [["${agentapi_status}"=="stable" ]];then
echo"AgentAPI stable"
break
else
echo"Waiting for AgentAPI to report stable status (attempt${attempt}/120)"
sleep 5
continue
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately it looks like we may need another wait here, as agentapi will become stable before it starts processing the task. We probably need to wait until the prompt shows up in the messages endpoint or something.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This ended up looking very similar to what we'd wantcoder exp task status --watch to be. Will update in a separate PR.

id:generate-summary
env:
ARCHIVE_URL:${{ steps.create-archive.outputs.archive_url }}
APP_SLUG:ccw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know we have the required envs check, but I'm wondering if it'd be better to define thesetraiage.sh envs in one place so they're applied to all action steps?

Mayhaps doing something like this early on:

echo "APP_SLUG=$APP_SLUG" >> "$GITHUB_ENV"

(There's probably a better way to do it.)

Or write atraiage.config.sh which can be sourced intraiage.sh.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Long-term I want to remove the need for this (e.g by usingcoder task send). Leaving it here, exposed and ugly, makes it easier to delete later IMO.

mafredri reacted with thumbs up emoji
fi

# AgentAPI application should not be 404'ing
agentapi_app_status_code=$(curl \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We could be fancy, look up the app URL and do assh bash 'while :; curl; if ...; fi; done'.

The only motivation here is to reduce coderd load, though.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As with app_slug above, I'm disinclined to do fanciness if it can later be incorporated into the CLI.

mafredri reacted with thumbs up emoji
@johnstcnjohnstcn merged commit063e863 intomainSep 25, 2025
32 of 33 checks passed
@johnstcnjohnstcn deleted the cj/traiage/integrate-tasks branchSeptember 25, 2025 15:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@DanielleMaywoodDanielleMaywoodDanielleMaywood left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@mafredri@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp