- Notifications
You must be signed in to change notification settings - Fork1k
ci: fix shellcheck lint error#19933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
hugodutka previously approved these changesSep 24, 2025
Uh oh!
There was an error while loading.Please reload this page.
When running `make lint` locally the GitHub action linter complainedabout missing double quotes around the `gotestsum` command. Thiscommit adds the double quotes around the `$NUM_PARALLEL_PACKAGES` and`$NUM_PARALLEL_TESTS $TESTCOUNT` variables.```bash.github/workflows/nightly-gauntlet.yaml:90:9: shellcheck reported issue in this script: SC2086:info:56:25: Double quote to prevent globbing and word splitting [shellcheck]```
cd25eec to6c17ebeComparehugodutka approved these changesSep 24, 2025
77d19c9 intomain 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
make lintlocally, the GitHub action linter complained about missing double quotes around thegotestsumcommand. This PR adds the double quotes around the$NUM_PARALLEL_PACKAGESand$NUM_PARALLEL_TESTS $TESTCOUNTvariables.