- Notifications
You must be signed in to change notification settings - Fork1k
fix: force task to be created with latest version#19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| returna.Name.localeCompare(b.Name); | ||
| } | ||
| // TODO: Enforce task creation to always use the latest active template version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: this is rather FIXME than TODO :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IsFIXME a valid thing? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, we have a lot of fixmes in our codebase :)
PS. nit-pick!
| }); | ||
| awaitstep("Uses latest template version",()=>{ | ||
| expect(API.experimental.createTask).toHaveBeenCalledWith( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Correct me if I'm wrong, but since this is a story not a unit test, you shouldn't assert API calls on that level?
Can we convert it to jest test instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We’re using Storybook as our main testing tool. At some point, Jest will only be used for testing functions or other non-component-related code. Kayla did an awesome L&L yesterday about the FE state—I’m just trying to grab the link to share here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, TIL!
…atest-template-version
| }); | ||
| awaitstep("Uses latest template version",()=>{ | ||
| expect(API.experimental.createTask).toHaveBeenCalledWith( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, TIL!
| returna.Name.localeCompare(b.Name); | ||
| } | ||
| // TODO: Enforce task creation to always use the latest active template version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, we have a lot of fixmes in our codebase :)
PS. nit-pick!
5ff503b intomainUh oh!
There was an error while loading.Please reload this page.
Fixes#19744