Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: don't redirect to task page when it is created#19919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/avoid-auto-redirect
Sep 24, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

Demo:

Screen.Recording.2025-09-22.at.15.02.49.mov

Closes#19675

@BrunoQuaresmaBrunoQuaresma self-assigned thisSep 22, 2025
@BrunoQuaresmaBrunoQuaresma requested a review froma teamSeptember 22, 2025 18:24
@BrunoQuaresmaBrunoQuaresma changed the titlefeat: not redirect to task page when it is createdfeat: don't redirect to task page when it is createdSep 22, 2025
Copy link
Member

@bpmctbpmct left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why does it spin for so long? I feel like it should be instant

@BrunoQuaresma
Copy link
CollaboratorAuthor

@bpmct no worries — this PR didn’t change anything that would increase latency or loading time. The slowness is probably due to my workspace connection and the latency of accessing dev.coder.com from Brazil.

@bpmct
Copy link
Member

It took 12 seconds for the task to create. I'm a bit confused on why that is

@BrunoQuaresma
Copy link
CollaboratorAuthor

@bpmct I know, but as I mentioned, this is just due to my workspace connection issues today. You can double-check the code, but no BE endpoints were changed, so you should expect the same loading time as before when creating a new task indev.coder.com.

Copy link
Member

@bpmctbpmct left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hmm ok. removing that but I want to test it in dogfood. we definitely don't want this loading bar to run for around 10 seconds

@bpmctbpmct requested review frombpmct and removed request forbpmctSeptember 22, 2025 19:05
Copy link
Member

@bpmctbpmct left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i guess i have to approve bc i requested changes but this isn't an approval of the code

@BrunoQuaresma
Copy link
CollaboratorAuthor

@bpmct that’s totally fair 👍

@BrunoQuaresmaBrunoQuaresma requested review frombcpeinhardt and removed request fora teamSeptember 23, 2025 17:27
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@BrunoQuaresmaBrunoQuaresma merged commit6d0943a intomainSep 24, 2025
36 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/avoid-auto-redirect branchSeptember 24, 2025 13:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@bpmctbpmctbpmct approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac is a code owner

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

@bcpeinhardtbcpeinhardtAwaiting requested review from bcpeinhardt

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve task creation UX: avoid auto-redirect to encourage background agent workflow
3 participants
@BrunoQuaresma@bpmct@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp