Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add public RBAC scope catalog for user-requestable permissions#19913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ThomasK33 merged 1 commit intomainfromthomask33/09-22-add_curated_scope_catalog
Sep 26, 2025

Conversation

ThomasK33
Copy link
Member

Add a curated catalog of public RBAC scopes

This PR introduces a curated catalog of public RBAC scopes that are exposed to users. It adds:

  • ApublicLowLevel map inscopes_catalog.go that defines which resource:action pairs are user-requestable
  • IsPublicLowLevel() function to check if a scope is in the public catalog
  • PublicLowLevelScopeNames() function that returns a sorted list of public scopes
  • Tests to verify the catalog entries are valid and properly sorted
  • Updated documentation in the check-scopes README to clarify that public scopes should be added to this catalog

This change helps distinguish between internal-only scopes and those that should be exposed to users in the API.

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedSep 22, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewSeptember 22, 2025 13:50
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch fromfdb2822 to4f64c51CompareSeptember 22, 2025 14:17
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch from4f64c51 tocaa7377CompareSeptember 22, 2025 15:28
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from6de9975 to99afbd9CompareSeptember 22, 2025 15:28
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch fromcaa7377 tobf1e4e9CompareSeptember 22, 2025 16:33
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from99afbd9 to6a22bccCompareSeptember 22, 2025 16:33
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The namePublicLowLevel feels strange. We could probably just call itPublic? OrExternal to mirror theInternal language you have in the comments.

@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from6a22bcc to2dc79e0CompareSeptember 22, 2025 17:03
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch frombf1e4e9 to76ae5abCompareSeptember 22, 2025 17:03
@ThomasK33Graphite App
Copy link
MemberAuthor

The namePublicLowLevel feels strange. We could probably just call itPublic? OrExternal to mirror theInternal language you have in the comments.

I updated it toIsPublicScope andPublicScopeNames in#19917.
I'll look into splitting off those changes and squashing them into this PR.

OrExternal to mirror theInternal language you have in the comments.

I don'treally have a preference here. When I initially named it, I was thinking ofpublic andprivate regarding OOP and field access. I am happy to rename it to better match our existing (user-facing) nomenclature.

@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from2dc79e0 to92537e5CompareSeptember 22, 2025 17:27
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch from76ae5ab tof1eed85CompareSeptember 22, 2025 17:28
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from92537e5 to4810c5eCompareSeptember 22, 2025 17:42
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch 3 times, most recently fromc96c93d to0ae1500CompareSeptember 23, 2025 08:53
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from4810c5e to6d04e1cCompareSeptember 23, 2025 08:53
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch 2 times, most recently fromb7ba894 tof8099fdCompareSeptember 23, 2025 20:53
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch from6d04e1c to49feb2dCompareSeptember 23, 2025 20:53
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch fromf8099fd tofbe5b58CompareSeptember 24, 2025 08:36
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch 2 times, most recently fromeddb2a7 toab8574eCompareSeptember 24, 2025 16:07
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch frombff79c8 to62cab0fCompareSeptember 24, 2025 16:07
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch fromab8574e tocffaa05CompareSeptember 24, 2025 16:09
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch from62cab0f to5ede22eCompareSeptember 24, 2025 16:09
@ThomasK33ThomasK33force-pushed thethomask33/09-19-feat_add_scope_constants_generation branch fromcffaa05 to84de60eCompareSeptember 24, 2025 16:27
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch from5ede22e toefcde0dCompareSeptember 24, 2025 16:27
@ThomasK33ThomasK33 changed the base branch fromthomask33/09-19-feat_add_scope_constants_generation tographite-base/19913September 24, 2025 16:40
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch fromefcde0d to7b2678bCompareSeptember 24, 2025 16:40
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/19913 tomainSeptember 24, 2025 16:41
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch 5 times, most recently from8e56891 to2cddda5CompareSeptember 25, 2025 15:46
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch 2 times, most recently from6258186 to4f84ffaCompareSeptember 25, 2025 16:05
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nothing blocking

Add public low-level scope catalog to RBAC system with curated set ofuser-requestable scopes. Includes workspace, template, API key, file,personal user, and user secret scopes. Updates scope checkingdocumentation to reference new catalog location in rbac package.
@ThomasK33ThomasK33force-pushed thethomask33/09-22-add_curated_scope_catalog branch from4f84ffa to6466375CompareSeptember 26, 2025 07:45
@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedSep 26, 2025•
edited
Loading

Merge activity

  • Sep 26, 9:30 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Sep 26, 9:30 AM UTC:@ThomasK33 merged this pull request withGraphite.

@ThomasK33ThomasK33 merged commit47c92ad intomainSep 26, 2025
33 checks passed
@ThomasK33ThomasK33 deleted the thomask33/09-22-add_curated_scope_catalog branchSeptember 26, 2025 09:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 26, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ThomasK33@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp