Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Use consistent colors for links and highlighting#1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 3 commits intomainfromabhineetjain/1940-consistent-colors
Jun 3, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedJun 2, 2022•
edited
Loading

This PR uses the new purple color for highlighting links and other focus elements.

Subtasks

  • move the chip color from user roles to the palette.
  • use the palette color in places we need to update.

Fixes#1940

Screenshots

User roles

Screen Shot 2022-06-02 at 11 56 02 AM

Side-navbar

Screen Shot 2022-06-02 at 11 55 48 AM

Navbar

Screen Shot 2022-06-02 at 11 55 37 AM

Builds table

Screen Shot 2022-06-02 at 11 58 08 AM

User dropdown menu

Screen Shot 2022-06-02 at 12 08 53 PM

This one is probably unused, but it was part of a story so updated it in case we end up using the component in the future:
Screen Shot 2022-06-02 at 12 19 55 PM

@AbhineetJainAbhineetJain requested a review froma team as acode ownerJune 2, 2022 15:54
@@ -11,6 +11,7 @@ export const darkPalette: PaletteOptions = {
secondary: {
main: "#008510",
contrastText: "#f8f8f8",
dark: "#7057FF",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice

@Kira-Pilot
Copy link
Member

I'm wondering if we could also use it on our dropdown borders. It kind of bugs me that the border of the user dropdown is blue when the role chips are purple:
Screen Shot 2022-06-02 at 12 04 44 PM
What do you think?

@AbhineetJain
Copy link
ContributorAuthor

I'm wondering if we could also use it on our dropdown borders. It kind of bugs me that the border of the user dropdown is blue when the role chips are purple. What do you think?

@Kira-Pilot Sounds perfect!

Kira-Pilot reacted with hooray emoji

@AbhineetJainAbhineetJain merged commitd6e9eab intomainJun 3, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/1940-consistent-colors branchJune 3, 2022 14:16
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* feat: consistent highlight colors* update user dropdown menu border* update borderedmenurow active color
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make colors in the UI consistent for links and highlights
2 participants
@AbhineetJain@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp