Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(scaletest): support exposing arbitrary metrics on scaletest runs#19886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/metrics-map-scaletest-runs
Sep 22, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 19, 2025
edited
Loading

Relates tocoder/internal#889

The existing implementation for exposing read and written bytes was a little awkward - we're going to be adding a bunch of scaletest runners / load generators thatdon't transfer any bytes. This PR has the scaletest reports expose a map of arbitrary string-keyed metrics instead.

FWIW, the latest iteration of the scaletesting infrastructure doesn't parse these reports right now - they're just logged to stdout, so we're good to break the json schema here.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedSep 19, 2025
edited
Loading

@ethanndicksonethanndicksonforce-pushed theethan/createusers-scaletest-runner branch from8a1d6eb tofe4ed6bCompareSeptember 19, 2025 06:12
@ethanndicksonethanndicksonforce-pushed theethan/metrics-map-scaletest-runs branch 3 times, most recently from2dc9632 toe2bbf36CompareSeptember 19, 2025 06:32
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 19, 2025 06:32
@ethanndicksonethanndicksonforce-pushed theethan/createusers-scaletest-runner branch fromfe4ed6b to855b5c1CompareSeptember 22, 2025 01:15
@ethanndicksonethanndicksonforce-pushed theethan/metrics-map-scaletest-runs branch 3 times, most recently from8953d8f tof2294d5CompareSeptember 22, 2025 05:22
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedSep 22, 2025
edited
Loading

Merge activity

  • Sep 22, 7:25 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Sep 22, 7:37 AM UTC:Graphite rebased this pull request as part of a merge.
  • Sep 22, 7:45 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/createusers-scaletest-runner tographite-base/19886September 22, 2025 07:26
@ethanndicksonethanndickson changed the base branch fromgraphite-base/19886 tomainSeptember 22, 2025 07:35
@ethanndicksonethanndicksonforce-pushed theethan/metrics-map-scaletest-runs branch fromf2294d5 tob7f73c5CompareSeptember 22, 2025 07:36
@ethanndicksonethanndickson merged commite13fcaf intomainSep 22, 2025
32 checks passed
@ethanndicksonethanndickson deleted the ethan/metrics-map-scaletest-runs branchSeptember 22, 2025 07:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@spikecurtis

[8]ページ先頭

©2009-2025 Movatter.jp