- Notifications
You must be signed in to change notification settings - Fork1k
fix: fix for template dormancy hour/day toggle#19884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Test hours to days conversion (26 hours → 2 days)- Test days to hours conversion- Test specific bug case from issue#15451- Validates the fix for template dormancy hour/day toggle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The fix looks good to me, but before approving it, let’s make sure the tests are passing. I also see some Storybook tests failing on CI.
Uh oh!
There was an error while loading.Please reload this page.
The onChange handler was using the old field value instead of calculatingthe correct conversion from milliseconds, causing days-to-hours conversionto fail. Fixed by using currentDurationMs consistently.🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Don't forget to access Chromatic to check the snapshots and approve them 👍
aaa5071 intomainUh oh!
There was an error while loading.Please reload this page.
resolves#15451
tested with 26hrs saved, then toggled to days. result = value changed to 2 days
If you have used AI to produce some or all of this PR, please ensure you have read ourAI Contribution guidelines before submitting.
blink helped