- Notifications
You must be signed in to change notification settings - Fork1k
fix: make app tabs scrollable#19881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@aslilac I’m going to re-request your review since I had to refactor a bit to fix conflicts with main. The changes aren’t too significant, though. |
@kacpersaw I’m requesting your review since you added the subdomain warning in the task feature and I had to resolve a few conflicts. The biggest changes are that I moved it into the app iframe component (so each app can handle its own state) and I added a story to ensure it’s tested. Please let me know if you have any questions! |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| activeApp?.subdomain&&!proxy.proxy?.wildcard_hostname; | ||
| constapps=getTaskApps(task); | ||
| const[embeddedApps,externalApps]=splitEmbeddedAndExternalApps(apps); | ||
| const[activeAppId,setActiveAppId]=useState(embeddedApps.at(0)?.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| const[activeAppId,setActiveAppId]=useState(embeddedApps.at(0)?.id); | |
| const[activeAppId,setActiveAppId]=useState(embeddedApps[0]?.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like to useat because it is type safe handling undefined values. Wdyt?
@aslilac thanks a lot for all your reviews! I’m going to merge this PR now, but please let me know if I missed anything. |
e7d648f intomainUh oh!
There was an error while loading.Please reload this page.
The solution follows the way VSCode manages its tabs. Since many other editors use a similar approach, this feels familiar and intuitive for our users.
Demo:
Screen.Recording.2025-09-18.at.16.05.58.mov
Fix#19438