Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: upgrade Node.js from 20.19.4 to 22.19.0 and update dependencies#19870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ThomasK33 merged 1 commit intomainfromthomask33/nix-flake-node-bump
Sep 18, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedSep 18, 2025
edited
Loading

Update Node.js from 20.19.4 to 22.19.0

This PR updates Node.js from v20.19.4 to v22.19.0 across the codebase. The change includes:

  • Updated Node.js version in GitHub Actions setup-node workflow
  • Updated Node.js version in the dogfood Dockerfile
  • Changed frompkgs.nodejs_20 tounstablePkgs.nodejs_22 in the Nix flake
  • Updated the Node.js engine version constraints in package.json files to allow Node.js 22
  • Updated Playwright from v1.47.0 to v1.50.1
  • Updated tzdata dependency from v1.0.44 to v1.0.46
  • Updated the flake.lock file with latest nixpkgs references

The PR also improves the error message for Playwright version mismatches by showing the actual versions in the error.

@ThomasK33ThomasK33 changed the titlechore: Bump node engine versionchore: bump node engine versionSep 18, 2025
@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch fromf2ec4af to241294bCompareSeptember 18, 2025 10:31
@aslilac
Copy link
Member

if everything still seems to work on 22 I'd be happy for us to upgrade. we need to upgrade everyone tho. for reference, here's the most recently merged node upgrade:

https://github.com/coder/coder/pull/19188/files

ThomasK33 reacted with thumbs up emoji

@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch 5 times, most recently from3622f3e to3e3a767CompareSeptember 18, 2025 16:57
@ThomasK33Graphite App
Copy link
MemberAuthor

Thanks, I've overlooked those.
Updated the dogfood Docker image and the setup-node action.

Also, in Node 22, Node’s Intl timezone support is slightly different from tzdata (e.g., “America/Coyhaique” exists in tzdata but is rejected by Intl/dayjs). Hence, the tests started failing on the 22 version.
I've added a filter for tzdata zones, removing all zones that Intl throws on, so that we only use timezones the Node runtime can parse.

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedSep 18, 2025
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@aslilac
Copy link
Member

Also, in Node 22, Node’s Intl timezone support is slightly different from tzdata

it's not that, the version you picked just has an older version of the database

v22.14.0/tz-version.txt -> 2024b
v22.19.0/tz-version.txt -> 2025b

@aslilac
Copy link
Member

aslilac commentedSep 18, 2025
edited
Loading

I'm kind of a nix noob but this shows 22.18, which uses 2025b.

https://search.nixos.org/packages?channel=25.05&show=nodejs_22&query=nodejs_22

@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch from3e3a767 to4e7f6cbCompareSeptember 18, 2025 20:10
In the nix flake's devshell, we used `nodejs_20` (20.18.3).`vite@7.1.4` requires a newer node version (^20.19.0).This commit bumps the flake's node version to `nodejs_22`, andupdates the allowed engine versions in the sites package.json.```bash❯ make gengenerateok      github.com/coder/coder/v2/coderd/database/gentest       0.649sok      github.com/coder/coder/v2/cli   3.258sok      github.com/coder/coder/v2/coderd        3.655sok      github.com/coder/coder/v2/coderd/notifications  3.322sok      github.com/coder/coder/v2/enterprise/cli        2.238sok      github.com/coder/coder/v2/enterprise/tailnet    0.741sok      github.com/coder/coder/v2/helm/coder/tests      2.891sok      github.com/coder/coder/v2/helm/provisioner/tests        1.336sok      github.com/coder/coder/v2/provisioner/terraform 0.755sok      github.com/coder/coder/v2/tailnet       0.697s+ pnpm installLockfile is up to date, resolution step is skipped ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)Your Node version is incompatible with "vite@7.1.4(@types/node@20.17.16)(jiti@2.4.2)(yaml@2.7.0)".Expected version: ^20.19.0 || >=22.12.0Got: v20.18.3This is happening because the package's manifest has an engines.node field specified.To fix this issue, install the required Node version.make: *** [Makefile:416: site/node_modules/.installed] Error 1```
@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch from4e7f6cb to96684bfCompareSeptember 18, 2025 20:27
@ThomasK33Graphite App
Copy link
MemberAuthor

I'm kind of a nix noob but this shows 22.18, which uses 2025b.

https://search.nixos.org/packages?channel=25.05&show=nodejs_22&query=nodejs_22

Kinda. We're still on the24.11 release channel.
We could update to 25.05, but then we need to update all other tools in the dogfood image.

I've now pulled in the nodejs_22 from the unstable nixpkgs, which is v22.19.0.

Thanks Kayla.

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

code looks perfect! thanks!

might update the pr title before you merge tho, this is a bit more than just bumping the engine field now :)

@ThomasK33ThomasK33 changed the titlechore: bump node engine versionchore: upgrade Node.js from 20.19.4 to 22.19.0 and update dependenciesSep 18, 2025
@ThomasK33ThomasK33 merged commit4d8dc22 intomainSep 18, 2025
41 checks passed
@ThomasK33ThomasK33 deleted the thomask33/nix-flake-node-bump branchSeptember 18, 2025 21:08
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ThomasK33@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp