- Notifications
You must be signed in to change notification settings - Fork1k
chore: upgrade Node.js from 20.19.4 to 22.19.0 and update dependencies#19870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
f2ec4af
to241294b
Compareif everything still seems to work on 22 I'd be happy for us to upgrade. we need to upgrade everyone tho. for reference, here's the most recently merged node upgrade: |
3622f3e
to3e3a767
CompareThanks, I've overlooked those. Also, in Node 22, Node’s Intl timezone support is slightly different from tzdata (e.g., “America/Coyhaique” exists in tzdata but is rejected by Intl/dayjs). Hence, the tests started failing on the 22 version. |
ThomasK33 commentedSep 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
it's not that, the version you picked just has an older version of the database v22.14.0/tz-version.txt -> 2024b |
aslilac commentedSep 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm kind of a nix noob but this shows 22.18, which uses 2025b. https://search.nixos.org/packages?channel=25.05&show=nodejs_22&query=nodejs_22 |
3e3a767
to4e7f6cb
CompareIn the nix flake's devshell, we used `nodejs_20` (20.18.3).`vite@7.1.4` requires a newer node version (^20.19.0).This commit bumps the flake's node version to `nodejs_22`, andupdates the allowed engine versions in the sites package.json.```bash❯ make gengenerateok github.com/coder/coder/v2/coderd/database/gentest 0.649sok github.com/coder/coder/v2/cli 3.258sok github.com/coder/coder/v2/coderd 3.655sok github.com/coder/coder/v2/coderd/notifications 3.322sok github.com/coder/coder/v2/enterprise/cli 2.238sok github.com/coder/coder/v2/enterprise/tailnet 0.741sok github.com/coder/coder/v2/helm/coder/tests 2.891sok github.com/coder/coder/v2/helm/provisioner/tests 1.336sok github.com/coder/coder/v2/provisioner/terraform 0.755sok github.com/coder/coder/v2/tailnet 0.697s+ pnpm installLockfile is up to date, resolution step is skipped ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version)Your Node version is incompatible with "vite@7.1.4(@types/node@20.17.16)(jiti@2.4.2)(yaml@2.7.0)".Expected version: ^20.19.0 || >=22.12.0Got: v20.18.3This is happening because the package's manifest has an engines.node field specified.To fix this issue, install the required Node version.make: *** [Makefile:416: site/node_modules/.installed] Error 1```
4e7f6cb
to96684bf
Compare
Kinda. We're still on the24.11 release channel. I've now pulled in the nodejs_22 from the unstable nixpkgs, which is v22.19.0. Thanks Kayla. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
code looks perfect! thanks!
might update the pr title before you merge tho, this is a bit more than just bumping the engine field now :)
Uh oh!
There was an error while loading.Please reload this page.
4d8dc22
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Update Node.js from 20.19.4 to 22.19.0
This PR updates Node.js from v20.19.4 to v22.19.0 across the codebase. The change includes:
pkgs.nodejs_20
tounstablePkgs.nodejs_22
in the Nix flakeThe PR also improves the error message for Playwright version mismatches by showing the actual versions in the error.