Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: ui autostop extension#1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greyscaled merged 5 commits intomainfromvapurrmaid/gh-1460/ui-autostop-extension
Jun 2, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaledgreyscaled commentedJun 2, 2022•
edited
Loading

Resolves:#1460

Summary:

An 'Extend' CTA on workspace schedule banner is added so that a user can
extend their workspace lease from the UI.

Details:

  • feat: putWorkspaceExtension handler

  • refactor: TypesGen dflt import in workspace.ts

  • feat: defaultWorkspaceExtension util

Impact:

This completes the UI<-->CLI parity epic in an MVP way. Of course, a
future improvement to make is extending by times other than the default
90 minutes.

Demo

extend-screenshot

I'll make a GIF demo later

Machine

banner-machine

Resolves:#1460Summary:An 'Extend' CTA on workspace schedule banner is added so that a user canextend their workspace lease from the UI.Details:* feat: putWorkspaceExtension handler* refactor: TypesGen dflt import in workspace.ts* feat: defaultWorkspaceExtension utilImpact:This completes the UI<-->CLI parity epic in an MVP way. Of course, afuture improvement to make is extending by times other than the default90 minutes.
@greyscaledgreyscaled self-assigned thisJun 2, 2022
@greyscaledgreyscaled requested a review fromjohnstcnJune 2, 2022 15:47
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

BE = 👍

@greyscaledgreyscaled marked this pull request as ready for reviewJune 2, 2022 15:56
@greyscaledgreyscaled requested a review froma team as acode ownerJune 2, 2022 15:56
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice job! looks good to me.

@greyscaledgreyscaled merged commit0b59ed3 intomainJun 2, 2022
@greyscaledgreyscaled deleted the vapurrmaid/gh-1460/ui-autostop-extension branchJune 2, 2022 19:44
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Resolves:#1460Summary:An 'Extend' CTA on workspace schedule banner is added so that a user canextend their workspace lease from the UI.Details:* feat: putWorkspaceExtension handler* refactor: TypesGen dflt import in workspace.ts* feat: defaultWorkspaceExtension utilImpact:This completes the UI<-->CLI parity epic in an MVP way. Of course, afuture improvement to make is extending by times other than the default90 minutes.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@greyscaledgreyscaled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI auto-stop extension
3 participants
@greyscaled@johnstcn@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp