- Notifications
You must be signed in to change notification settings - Fork1k
feat: add coder_workspace_port_forward MCP tool#19863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // setupWorkspaceForAgent creates a workspace setup exactly like main SSH tests | ||
| // nolint:gocritic // This is in a test package and does not end up in the build | ||
| funcsetupWorkspaceForAgent(t*testing.T) (*codersdk.Client, database.WorkspaceTable,string) { | ||
| funcsetupWorkspaceForAgent(t*testing.T,opts*coderdtest.Options) (*codersdk.Client, database.WorkspaceTable,string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a super minor nit: We could have left this function and its signature unchanged, added a newsetupWorkspaceForAgentWithOptions, and made this function call the new one internally withnil options.
That way, all other code remains untouched, resulting in an even smaller diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I had the same thought but, I felt like I was trading diff size for dev experience. Because this is basically is a convenience wrapper aroundcoderdtest.NewWithDatabase, having a similar signature makes it consistent and predictable, and easier to add options in the future (no need to discover that aWithOptions version exists).
I do wish I could merge this in a separate commit though, without having to open a second PR.
f1e7942 to02c889eCompare7f56212 intomainUh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#784