Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add lint check for API key scope enum completeness#19862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedSep 17, 2025•
edited
Loading

Added a script/linter to ensure allpolicy.RBACPermissions entries are part of theapi_key_scope enumerated in thecoderd/database/dump.sql file.

Fixes#19846

@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from2ba5550 toe548168CompareSeptember 17, 2025 17:50
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch fromab95a1f to9bc8879CompareSeptember 17, 2025 17:51
@ThomasK33ThomasK33 changed the titlefeat: API key scopes database migrationfeat: implement API key scopes database enum linterSep 17, 2025
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from9bc8879 to4afb40eCompareSeptember 17, 2025 17:54
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 2 times, most recently from1760157 to7a7e6adCompareSeptember 17, 2025 19:49
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from4afb40e to1ae7af6CompareSeptember 17, 2025 21:34
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from7a7e6ad to1aba733CompareSeptember 18, 2025 10:37
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch 2 times, most recently from0ccc74c toc00de78CompareSeptember 18, 2025 11:13
@ThomasK33ThomasK33 linked an issueSep 18, 2025 that may beclosed by this pull request
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from1aba733 to99b5b53CompareSeptember 18, 2025 11:26
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch fromc00de78 to9b40119CompareSeptember 18, 2025 11:26
@ThomasK33ThomasK33 marked this pull request as ready for reviewSeptember 18, 2025 13:21
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from9b40119 todbe6a63CompareSeptember 18, 2025 13:37
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 2 times, most recently fromdb8b42e to32e7137CompareSeptember 18, 2025 17:01
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch fromdbe6a63 to4e8a5c3CompareSeptember 18, 2025 17:01
@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedSep 18, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from32e7137 to682511cCompareSeptember 18, 2025 17:14
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from4e8a5c3 tod6334f6CompareSeptember 18, 2025 17:15
@ThomasK33ThomasK33 marked this pull request as draftSeptember 18, 2025 17:19
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from682511c to0fd28dbCompareSeptember 18, 2025 20:10
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from5b28178 toec2d8fbCompareSeptember 22, 2025 13:47
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch fromce47b02 to37f92feCompareSeptember 22, 2025 13:47
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from37f92fe to9c60b1fCompareSeptember 22, 2025 15:28
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch fromec2d8fb to782f1c7CompareSeptember 22, 2025 15:28
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from9c60b1f to2666417CompareSeptember 22, 2025 16:33
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 3 times, most recently from81b483f tob27f312CompareSeptember 22, 2025 17:03
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from2666417 to5dd94bbCompareSeptember 22, 2025 17:03
@ThomasK33ThomasK33 changed the base branch fromthomask33/19845-database-migrations-scopes-array-typed-allow-list tographite-base/19862September 22, 2025 17:26
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch from5dd94bb to3a1adbeCompareSeptember 22, 2025 17:27
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/19862 tomainSeptember 22, 2025 17:27
@ThomasK33ThomasK33force-pushed thethomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branch 6 times, most recently frome0432eb tob4b6ef1CompareSeptember 24, 2025 08:58
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sweet!

@ThomasK33ThomasK33 merged commitacc0890 intomainSep 24, 2025
33 checks passed
@ThomasK33ThomasK33 deleted the thomask33/19846-build-time-check-db-enum-contains-all-rbac-scopes branchSeptember 24, 2025 16:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build-time check: DB enum contains all RBAC scopes
2 participants
@ThomasK33@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp