Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: implement API key scopes database migration#19861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ThomasK33
Copy link
Member

Added database migration for API key scopes.

Fixes#19845

@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from2ba5550 toe548168CompareSeptember 17, 2025 17:50
@ThomasK33ThomasK33 changed the titlefeat: API key scopes database migrationfeat: add database migration for API key scopesSep 17, 2025
@ThomasK33ThomasK33 changed the titlefeat: add database migration for API key scopesfeat: implement API key scopes database migrationSep 17, 2025
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 3 times, most recently from7a7e6ad to1aba733CompareSeptember 18, 2025 10:37
@ThomasK33ThomasK33 changed the base branch frommain tothomask33/nix-flake-node-bumpSeptember 18, 2025 10:37
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from1aba733 to99b5b53CompareSeptember 18, 2025 11:26
@ThomasK33ThomasK33 marked this pull request as ready for reviewSeptember 18, 2025 12:14
Emyrk
Emyrk previously requested changesSep 18, 2025
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from99b5b53 todb8b42eCompareSeptember 18, 2025 16:26
@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch from241294b to70b3a9fCompareSeptember 18, 2025 16:28
@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch 4 times, most recently from3622f3e to3e3a767CompareSeptember 18, 2025 16:57
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch fromdb8b42e to32e7137CompareSeptember 18, 2025 17:01
@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedSep 18, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from32e7137 to682511cCompareSeptember 18, 2025 17:14
@ThomasK33ThomasK33 marked this pull request as draftSeptember 18, 2025 17:19
@ThomasK33ThomasK33 dismissedEmyrk’sstale reviewSeptember 18, 2025 17:19

removing you, since I goofed up the git history and don't want to spam you. will rerequest in the future

@ThomasK33ThomasK33force-pushed thethomask33/nix-flake-node-bump branch from3e3a767 to4e7f6cbCompareSeptember 18, 2025 20:10
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from0fd28db toa1e7294CompareSeptember 18, 2025 20:28
@ThomasK33ThomasK33 marked this pull request as ready for reviewSeptember 18, 2025 20:30
@ThomasK33ThomasK33 changed the base branch fromthomask33/nix-flake-node-bump tographite-base/19861September 18, 2025 21:08
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch froma1e7294 to81ce34aCompareSeptember 18, 2025 21:09
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/19861 tomainSeptember 18, 2025 21:09
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 4 times, most recently fromae36958 to391fa21CompareSeptember 19, 2025 18:02
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 2 times, most recently from5b28178 toec2d8fbCompareSeptember 22, 2025 13:47
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch fromec2d8fb to782f1c7CompareSeptember 22, 2025 15:28
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small changes requested.

If the changes want to be pushed to another PR, we just need to open issues to address them.

@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch 2 times, most recently from0eb0644 to81b483fCompareSeptember 22, 2025 16:53
…w listReplace the single `scope` column with `scopes` array and add `allow_list`column to API keys table. This enables fine-grained authorization controlusing low-level resource:action permissions while maintaining backwardcompatibility.- Add database migration extending api_key_scope enum with all RBAC  permissions- Replace APIKey.Scope with APIKey.Scopes array and AllowList fields- Implement APIKeyScopes.Expand() method for multi-scope authorization- Add AllowList type with database serialization support- Update RBAC scope expansion to support resource:action format- Maintain response compatibility by deriving single scope from arrays- Add comprehensive test coverage for scope expansion logic
@ThomasK33ThomasK33force-pushed thethomask33/19845-database-migrations-scopes-array-typed-allow-list branch from81b483f tob27f312CompareSeptember 22, 2025 17:03
@ThomasK33ThomasK33 merged commitfb0ce38 intomainSep 22, 2025
34 checks passed
@ThomasK33ThomasK33 deleted the thomask33/19845-database-migrations-scopes-array-typed-allow-list branchSeptember 22, 2025 17:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 22, 2025
@ThomasK33ThomasK33 linked an issueSep 24, 2025 that may beclosed by this pull request
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RBAC: Introduce composable API key scopes and expansion Database Migrations: scopes array + typed allow-list
2 participants
@ThomasK33@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp