- Notifications
You must be signed in to change notification settings - Fork924
feat: Add support for pprof incoder agent#1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we add a signal to enable this? Seems like that'd be the primary use-case.
Uh oh!
There was an error while loading.Please reload this page.
@kylecarbs what type of signaling were you thinking? Kill signal? That could definitely be useful! |
Not sure what signal... maybe |
@kylecarbs |
Hmm, how could we trigger it for Windows? I'd love a cross-platform approach first, so that we're not stuck when a Windows user is experiencing bugs. |
@kylecarbs I was thinking we could trigger it via the server as an alternative. This could allow an admin to turn it on as well as let the user do it via the CLI. This could be further expanded as a admin toggle in the future (whether or not it’s allowed, not sure if there’s a use case though). Another option could be IPC via cli and the running agent. |
Ahh, interesting. This is big progress though, so I think an issue should be made for the Windows support and we merge! |
@kylecarbs done. I created#2081 to track support for Windows. |
* feat: Allow USR1 signal to start pprof
Uh oh!
There was an error while loading.Please reload this page.
This PR adds support for starting a pprof server in
coder agent.After#1978 I wanted this to analyze the agent for memory leaks, as mentioned in#1508.