Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(coderd/notifications): avoid generating warning logs for trivial enqueue failures#19840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 4 commits intomainfromethan/notif-warning-logs
Sep 17, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 17, 2025•
edited
Loading

I noticed during a scaletest that many warning logs were being generated when enqueuing notifications. The error was:

failed to notify of workspace creation: notification is not enabled

I don't think we should be warning if automated notifications fail to send to users because they have them disabled.

To fix, we'll stop returning these errors.

@ethanndicksonGraphite App
Copy link
MemberAuthor

@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 17, 2025 04:13
@ethanndicksonethanndicksonforce-pushed theethan/notif-warning-logs branch 2 times, most recently from34deea9 to57bf72aCompareSeptember 17, 2025 06:21
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@ethanndicksonethanndickson merged commit356604e intomainSep 17, 2025
34 checks passed
@ethanndicksonethanndickson deleted the ethan/notif-warning-logs branchSeptember 17, 2025 08:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@ssncferreirassncferreiraAwaiting requested review from ssncferreira

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp